Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/bookmarks/browser/bookmark_model_unittest.cc

Issue 1379983002: Supporting undoing bookmark deletion without creating new ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address more feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_model_unittest.cc b/components/bookmarks/browser/bookmark_model_unittest.cc
index ac22fbf35892ef6a175ebe61cd0e9a1b23f0eb38..2fc800ac305068c0e619b34af7f743559c8bd1b4 100644
--- a/components/bookmarks/browser/bookmark_model_unittest.cc
+++ b/components/bookmarks/browser/bookmark_model_unittest.cc
@@ -332,12 +332,21 @@ class BookmarkModelTest : public testing::Test,
++before_remove_all_count_;
}
+ void GroupedBookmarkChangesBeginning(BookmarkModel* model) override {
+ ++grouped_changes_beginning_count_;
+ }
+
+ void GroupedBookmarkChangesEnded(BookmarkModel* model) override {
+ ++grouped_changes_ended_count_;
+ }
+
void ClearCounts() {
added_count_ = moved_count_ = removed_count_ = changed_count_ =
reordered_count_ = extensive_changes_beginning_count_ =
extensive_changes_ended_count_ = all_bookmarks_removed_ =
before_remove_count_ = before_change_count_ = before_reorder_count_ =
- before_remove_all_count_ = 0;
+ before_remove_all_count_ = grouped_changes_beginning_count_ =
+ grouped_changes_ended_count_ = 0;
}
void AssertObserverCount(int added_count,
@@ -368,6 +377,14 @@ class BookmarkModelTest : public testing::Test,
EXPECT_EQ(extensive_changes_ended_count, extensive_changes_ended_count_);
}
+ void AssertGroupedChangesObserverCount(
+ int grouped_changes_beginning_count,
+ int grouped_changes_ended_count) {
+ EXPECT_EQ(grouped_changes_beginning_count,
+ grouped_changes_beginning_count_);
+ EXPECT_EQ(grouped_changes_ended_count, grouped_changes_ended_count_);
+ }
+
int AllNodesRemovedObserverCount() const { return all_bookmarks_removed_; }
BookmarkPermanentNode* ReloadModelWithExtraNode() {
@@ -405,6 +422,8 @@ class BookmarkModelTest : public testing::Test,
int before_change_count_;
int before_reorder_count_;
int before_remove_all_count_;
+ int grouped_changes_beginning_count_;
+ int grouped_changes_ended_count_;
DISALLOW_COPY_AND_ASSIGN(BookmarkModelTest);
};
@@ -630,13 +649,18 @@ TEST_F(BookmarkModelTest, RemoveAllUserBookmarks) {
AssertObserverCount(3, 0, 0, 0, 0, 0, 0, 0, 0);
ClearCounts();
+ int permanent_node_count = model_->root_node()->child_count();
+
model_->RemoveAllUserBookmarks();
EXPECT_EQ(0, bookmark_bar_node->child_count());
+ // No permanent node should be removed.
+ EXPECT_EQ(permanent_node_count, model_->root_node()->child_count());
// No individual BookmarkNodeRemoved events are fired, so removed count
// should be 0.
AssertObserverCount(0, 0, 0, 0, 0, 0, 0, 0, 1);
AssertExtensiveChangesObserverCount(1, 1);
+ AssertGroupedChangesObserverCount(1, 1);
EXPECT_EQ(1, AllNodesRemovedObserverCount());
}

Powered by Google App Engine
This is Rietveld 408576698