Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: components/bookmarks/browser/bookmark_undo_delegate.h

Issue 1379983002: Supporting undoing bookmark deletion without creating new ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_undo_delegate.h
diff --git a/components/bookmarks/browser/bookmark_undo_delegate.h b/components/bookmarks/browser/bookmark_undo_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..0f68551189a99a163a73e5c18bd42110c18d03fa
--- /dev/null
+++ b/components/bookmarks/browser/bookmark_undo_delegate.h
@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UNDO_DELEGATE_H_
+#define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UNDO_DELEGATE_H_
+
+#include "base/memory/scoped_ptr.h"
+
+namespace bookmarks {
+
+class BookmarkModel;
+class BookmarkNode;
+class BookmarkUndoProvider;
+
+class BookmarkUndoDelegate {
sky 2015/10/08 15:20:01 Add a description.
jianli 2015/10/08 23:37:40 Done.
+ public:
+ // Called when |node| was deleted from |parent| at position |index|. The
sky 2015/10/08 15:20:00 deleted->rmeoted
jianli 2015/10/08 23:37:40 Done.
+ // delegate takes the ownership of the deleted node.
sky 2015/10/08 15:20:01 The second sentence is no longer needed as node is
jianli 2015/10/08 23:37:40 Done.
+ virtual void OnBookmarkNodeDeleted(BookmarkModel* model,
sky 2015/10/08 15:20:00 OnBookmarkNodeRemoved.
jianli 2015/10/08 23:37:40 Done.
+ BookmarkUndoProvider* provider,
sky 2015/10/08 15:20:00 Rather than supply the provider on event call how
jianli 2015/10/08 23:37:40 Done.
+ const BookmarkNode* parent,
+ int index,
+ scoped_ptr<BookmarkNode> node) = 0;
+
+ protected:
+ virtual ~BookmarkUndoDelegate() {}
+};
+
+
+} // namespace bookmarks
+
+#endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UNDO_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698