Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: components/undo/bookmark_undo_service.h

Issue 1379983002: Supporting undoing bookmark deletion without creating new ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 5 #ifndef COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
6 #define COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 6 #define COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/scoped_observer.h" 10 #include "base/scoped_observer.h"
11 #include "components/bookmarks/browser/base_bookmark_model_observer.h" 11 #include "components/bookmarks/browser/base_bookmark_model_observer.h"
12 #include "components/bookmarks/browser/bookmark_node_data.h" 12 #include "components/bookmarks/browser/bookmark_node_data.h"
13 #include "components/keyed_service/core/keyed_service.h" 13 #include "components/keyed_service/core/keyed_service.h"
14 #include "components/undo/bookmark_renumber_observer.h"
15 #include "components/undo/undo_manager.h" 14 #include "components/undo/undo_manager.h"
16 15
17 namespace bookmarks { 16 namespace bookmarks {
18 class BookmarkModel; 17 class BookmarkModel;
19 class BookmarkModelObserver; 18 class BookmarkModelObserver;
20 } 19 }
21 20
22 // BookmarkUndoService -------------------------------------------------------- 21 // BookmarkUndoService --------------------------------------------------------
23 22
24 // BookmarkUndoService is owned by the profile, and is responsible for observing 23 // BookmarkUndoService is owned by the profile, and is responsible for observing
25 // BookmarkModel changes in order to provide an undo for those changes. 24 // BookmarkModel changes in order to provide an undo for those changes.
26 class BookmarkUndoService : public bookmarks::BaseBookmarkModelObserver, 25 class BookmarkUndoService : public bookmarks::BaseBookmarkModelObserver,
27 public KeyedService, 26 public KeyedService {
28 public BookmarkRenumberObserver {
29 public: 27 public:
30 BookmarkUndoService(); 28 BookmarkUndoService();
31 ~BookmarkUndoService() override; 29 ~BookmarkUndoService() override;
32 30
33 // Starts the BookmarkUndoService and register it as a BookmarkModelObserver. 31 // Starts the BookmarkUndoService and register it as a BookmarkModelObserver.
34 // Calling this method is optional, but the service will be inactive until it 32 // Calling this method is optional, but the service will be inactive until it
35 // is called. 33 // is called.
36 void Start(bookmarks::BookmarkModel* model); 34 void Start(bookmarks::BookmarkModel* model);
37 35
38 UndoManager* undo_manager() { return &undo_manager_; } 36 UndoManager* undo_manager() { return &undo_manager_; }
(...skipping 21 matching lines...) Expand all
60 const bookmarks::BookmarkNode* node) override; 58 const bookmarks::BookmarkNode* node) override;
61 void OnWillRemoveAllUserBookmarks(bookmarks::BookmarkModel* model) override; 59 void OnWillRemoveAllUserBookmarks(bookmarks::BookmarkModel* model) override;
62 void OnWillChangeBookmarkNode(bookmarks::BookmarkModel* model, 60 void OnWillChangeBookmarkNode(bookmarks::BookmarkModel* model,
63 const bookmarks::BookmarkNode* node) override; 61 const bookmarks::BookmarkNode* node) override;
64 void OnWillReorderBookmarkNode(bookmarks::BookmarkModel* model, 62 void OnWillReorderBookmarkNode(bookmarks::BookmarkModel* model,
65 const bookmarks::BookmarkNode* node) override; 63 const bookmarks::BookmarkNode* node) override;
66 void GroupedBookmarkChangesBeginning( 64 void GroupedBookmarkChangesBeginning(
67 bookmarks::BookmarkModel* model) override; 65 bookmarks::BookmarkModel* model) override;
68 void GroupedBookmarkChangesEnded(bookmarks::BookmarkModel* model) override; 66 void GroupedBookmarkChangesEnded(bookmarks::BookmarkModel* model) override;
69 67
70 // BookmarkRenumberObserver: 68 bookmarks::BookmarkModel* model_;
71 void OnBookmarkRenumbered(int64 old_id, int64 new_id) override;
72
73 UndoManager undo_manager_; 69 UndoManager undo_manager_;
74 ScopedObserver<bookmarks::BookmarkModel, bookmarks::BookmarkModelObserver> 70 ScopedObserver<bookmarks::BookmarkModel, bookmarks::BookmarkModelObserver>
75 scoped_observer_; 71 scoped_observer_;
76 72
77 DISALLOW_COPY_AND_ASSIGN(BookmarkUndoService); 73 DISALLOW_COPY_AND_ASSIGN(BookmarkUndoService);
78 }; 74 };
79 75
80 #endif // COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_ 76 #endif // COMPONENTS_UNDO_BOOKMARK_UNDO_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698