third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl - Issue 1379863003: Added overloads of uniform[1234]uiv taking Uint32Array to match spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Issue 1379863003: Added overloads of uniform[1234]uiv taking Uint32Array to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo causing crashes in uniform API tests. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

index 0bbb3eb7e57da600548aaae91478a8645108967d..a50ea1f4d896a59ab04ea585dcf1b4b275c7029d 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

@@ -338,10 +338,14 @@ typedef long long GLint64;

void uniform2ui(WebGLUniformLocation? location, GLuint v0, GLuint v1);

void uniform3ui(WebGLUniformLocation? location, GLuint v0, GLuint v1, GLuint v2);

void uniform4ui(WebGLUniformLocation? location, GLuint v0, GLuint v1, GLuint v2, GLuint v3);

- void uniform1uiv(WebGLUniformLocation? location, sequence<GLuint> value);

- void uniform2uiv(WebGLUniformLocation? location, sequence<GLuint> value);

- void uniform3uiv(WebGLUniformLocation? location, sequence<GLuint> value);

- void uniform4uiv(WebGLUniformLocation? location, sequence<GLuint> value);

+ void uniform1uiv(WebGLUniformLocation? location, [FlexibleArrayBufferView] Uint32Array v);

+ void uniform1uiv(WebGLUniformLocation? location, sequence<GLuint> v);

+ void uniform2uiv(WebGLUniformLocation? location, [FlexibleArrayBufferView] Uint32Array v);

+ void uniform2uiv(WebGLUniformLocation? location, sequence<GLuint> v);

+ void uniform3uiv(WebGLUniformLocation? location, [FlexibleArrayBufferView] Uint32Array v);

+ void uniform3uiv(WebGLUniformLocation? location, sequence<GLuint> v);

+ void uniform4uiv(WebGLUniformLocation? location, [FlexibleArrayBufferView] Uint32Array v);

+ void uniform4uiv(WebGLUniformLocation? location, sequence<GLuint> v);

void uniformMatrix2x3fv(WebGLUniformLocation? location, GLboolean transpose, Float32Array value);

void uniformMatrix2x3fv(WebGLUniformLocation? location, GLboolean transpose, sequence<GLfloat> value);

void uniformMatrix3x2fv(WebGLUniformLocation? location, GLboolean transpose, Float32Array value);