Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1379863003: Added overloads of uniform[1234]uiv taking Uint32Array to match spec. (Closed)

Created:
5 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added overloads of uniform[1234]uiv taking Uint32Array to match spec. Also fixed typo in validation for uniform1uiv causing crashes in test. BUG=295792 Committed: https://crrev.com/ed4c93ce00a78fc6625573adb86c85e93aff193b Cr-Commit-Position: refs/heads/master@{#352159}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed typo causing crashes in uniform API tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -19 lines) Patch
M third_party/WebKit/Source/core/dom/TypedFlexibleArrayBufferView.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 3 chunks +33 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ken Russell (switch to Gerrit)
Please review. Tested with deqp/functional/gles3/uniformapi.html test. It makes more cases pass but the overall test ...
5 years, 2 months ago (2015-09-30 21:43:38 UTC) #2
Zhenyao Mo
LGTM
5 years, 2 months ago (2015-09-30 21:54:19 UTC) #3
bajones
LGTM too.
5 years, 2 months ago (2015-09-30 22:23:30 UTC) #4
Ken Russell (switch to Gerrit)
+jochen for FlexibleArrayBufferView change
5 years, 2 months ago (2015-09-30 22:29:43 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-02 13:24:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379863003/20001
5 years, 2 months ago (2015-10-02 21:02:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 22:47:20 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 22:48:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed4c93ce00a78fc6625573adb86c85e93aff193b
Cr-Commit-Position: refs/heads/master@{#352159}

Powered by Google App Engine
This is Rietveld 408576698