Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1377943005: Change StyleBuilderConverter functions to take const CSSValue&s (Closed)

Created:
5 years, 2 months ago by sashab
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@style_map_references
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change StyleBuilderConverter functions to take const CSSValue&s Change StyleBuilderConverter functions to take const CSSValue&s instead of CSSValue*s. Since these values can never be null, this makes the code easier to work with. BUG=526586 Committed: https://crrev.com/fdc999369aacd205cb488708de7623e6079e51ac Cr-Commit-Position: refs/heads/master@{#353243}

Patch Set 1 #

Patch Set 2 : Rebase onto other patches #

Patch Set 3 : Rebase onto other patches #

Patch Set 4 : Rebase #

Messages

Total messages: 13 (6 generated)
sashab
No const_cast<>s needed! :D
5 years, 2 months ago (2015-10-07 06:20:23 UTC) #3
Timothy Loh
lgtm
5 years, 2 months ago (2015-10-08 00:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377943005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377943005/60001
5 years, 2 months ago (2015-10-08 04:58:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/107615) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-08 05:00:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377943005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377943005/80001
5 years, 2 months ago (2015-10-09 05:36:00 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 2 months ago (2015-10-09 07:18:08 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 07:19:49 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fdc999369aacd205cb488708de7623e6079e51ac
Cr-Commit-Position: refs/heads/master@{#353243}

Powered by Google App Engine
This is Rietveld 408576698