Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 13779006: Fixed gear menu navigation using keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Applied the changes to the new interface html. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index 326573fa8fbd65485d57bf41dfe7a8036346b831..655f3542c606b36bf098accd9d3f2f6e48058829 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -63,6 +63,7 @@ function FileManager(dialogDom) {
DialogType.FULL_PAGE]);
this.selectionHandler_ = null;
+ this.ctrlKeyPressed_ = false;
this.metadataCache_ = MetadataCache.createFull();
this.volumeManager_ = VolumeManager.getInstance();
@@ -553,6 +554,9 @@ DialogType.isModal = function(type) {
false /* Without loading caption. */));
cr.ui.decorate(this.gearButton_, cr.ui.MenuButton);
+ this.dialogDom_.querySelector('#gear-menu').menuItemSelector =
+ 'menuitem, hr';
+
this.syncButton.checkable = true;
this.hostedButton.checkable = true;
};
@@ -1632,6 +1636,13 @@ DialogType.isModal = function(type) {
};
/**
+ * @return {boolean} True if the ctrl key is pressed now.
+ */
+ FileManager.prototype.isCtrlKeyPressed = function() {
+ return this.ctrlKeyPressed_;
+ };
+
+ /**
* @return {boolean} True if the "Available offline" column should be shown in
* the table layout.
*/
@@ -2050,6 +2061,8 @@ DialogType.isModal = function(type) {
FileManager.prototype.updateGearMenu_ = function() {
this.syncButton.hidden = !this.isOnDrive();
this.hostedButton.hidden = !this.isOnDrive();
+ this.document_.getElementById('drive-separator').hidden =
+ !this.isOnDrive();
// If volume has changed, then fetch remaining space data.
if (this.previousRootUrl_ != this.directoryModel_.getCurrentRootUrl())
@@ -2530,7 +2543,7 @@ DialogType.isModal = function(type) {
switch (util.getKeyModifiers(event) + event.keyCode) {
case 'Ctrl-17': // Ctrl => Show hidden setting
- this.dialogDom_.setAttribute('ctrl-pressing', 'true');
+ this.setCtrlKeyPressed_(true);
return;
case 'Ctrl-190': // Ctrl-. => Toggle filter files.
@@ -2575,7 +2588,7 @@ DialogType.isModal = function(type) {
switch (util.getKeyModifiers(event) + event.keyCode) {
case '17': // Ctrl => Hide hidden setting
- this.dialogDom_.removeAttribute('ctrl-pressing');
+ this.setCtrlKeyPressed_(false);
return;
}
};
@@ -3450,4 +3463,15 @@ DialogType.isModal = function(type) {
callback(prefs);
}.bind(this));
};
+
+ /**
+ * Set the flag expressing whether the ctrl key is pressed or not.
+ * @param {boolean} flag New value of the flag
+ * @private
+ */
+ FileManager.prototype.setCtrlKeyPressed_ = function(flag) {
+ this.ctrlKeyPressed_ = flag;
+ this.document_.querySelector('#drive-clear-local-cache').canExecuteChange();
+ this.document_.querySelector('#drive-reload').canExecuteChange();
+ };
})();

Powered by Google App Engine
This is Rietveld 408576698