Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 13775010: Fixed cache eviction in Files.app's slide mode. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Fixed cache eviction in Files.app's slide mode. Sometimes, prefetching was fast, which caused evicting the image being loaded from cache. As a result, full resolution image was not being loaded properly. This patch addresses this issue by evicting the full-resolution cache in advance, before loading an image from cache. As a result, there is always a space for cache, so there is a guarantee that the image just fetched from cache will not be evicted by the image being prefetched. TEST=Follow the bug's description. BUG=227264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193324

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/js/image_editor/image_view.js View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@yoshiki: PTAL at this tiny patch. Thanks.
7 years, 8 months ago (2013-04-08 16:28:04 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 8 months ago (2013-04-09 09:00:18 UTC) #2
mtomasz
On 2013/04/09 09:00:18, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 8 months ago (2013-04-10 01:13:29 UTC) #3
yoshiki
lgtm
7 years, 8 months ago (2013-04-10 02:51:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/13775010/4001
7 years, 8 months ago (2013-04-10 02:52:56 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 04:45:03 UTC) #6
Message was sent while issue was closed.
Change committed as 193324

Powered by Google App Engine
This is Rietveld 408576698