Remove DataModelWrapper from android build.

chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/android/autofill/autofill_dialog_result.h"
 #include "chrome/browser/ui/android/window_android_helper.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_common.h"
-#include "chrome/browser/ui/autofill/data_model_wrapper.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/content/browser/wallet/full_wallet.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #include "jni/AutofillDialogControllerAndroid_jni.h"
 #include "ui/base/android/window_android.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/combobox_model.h"
 #include "ui/base/models/menu_model.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "ui/gfx/rect.h"
 #include "url/gurl.h"
 
 namespace autofill {
 
 namespace {
 
+using wallet::FullWallet;
+
 // Keys in kAutofillDialogDefaults pref dictionary (do not change these values).
 const char kLastUsedAccountName[] = "last_used_account_name";
 const char kLastUsedChoiceIsAutofill[] = "last_used_choice_is_autofill";
 const char kLastUsedBillingAddressGuid[] = "last_used_billing";
 const char kLastUsedShippingAddressGuid[] = "last_used_shipping";
 const char kLastUsedCreditCardGuid[] = "last_used_card";
 
-scoped_ptr<DataModelWrapper> CreateWrapper(
-    DialogSection section, wallet::FullWallet* full_wallet) {
-  if (section == SECTION_CC_BILLING) {
-    if (!full_wallet->billing_address())
-      return scoped_ptr<DataModelWrapper>();
-
-    return scoped_ptr<DataModelWrapper>(
-        new FullWalletBillingWrapper(full_wallet));
-  }
-  if (section == SECTION_SHIPPING) {
-    if (!full_wallet->shipping_address())
-      return scoped_ptr<DataModelWrapper>();
-
-    return scoped_ptr<DataModelWrapper>(
-        new FullWalletShippingWrapper(full_wallet));
-  }
-  NOTREACHED();
-  return scoped_ptr<DataModelWrapper>();
+base::string16 NullGetInfo(const AutofillType& type) {
+  return base::string16();
 }
 
 void FillOutputForSectionWithComparator(
     DialogSection section,
     const DetailInputs& inputs,
-    const InputFieldComparator& compare,
+    const FormStructure::InputFieldComparator& compare,
     FormStructure& form_structure,
-    wallet::FullWallet* full_wallet,
+    FullWallet* full_wallet,
     const base::string16& email_address) {
-  scoped_ptr<DataModelWrapper> wrapper = CreateWrapper(section, full_wallet);
-  if (wrapper)
-    wrapper->FillFormStructure(inputs, compare, &form_structure);
+  base::Callback<base::string16(const AutofillType&)> get_info;
+  if (section == SECTION_CC_BILLING && full_wallet->billing_address()) {
+    get_info = base::Bind(&FullWallet::GetBillingInfo,
+                          base::Unretained(full_wallet),
+                          g_browser_process->GetApplicationLocale());
+  } else if (section == SECTION_SHIPPING && full_wallet->shipping_address()) {
+    get_info = base::Bind(&FullWallet::GetShippingInfo,
+                          base::Unretained(full_wallet),
+                          g_browser_process->GetApplicationLocale());
+  }

[Dan Beam, 2014/01/27 20:51:40]

i don't currently see how GetBillingInfo() could be called with shipping fields
nor how GetShippingInfo() could be called with billing fields with current code
(so GetInfo() should still be viable)

+
+  if (!get_info.is_null()) {
+    std::vector<ServerFieldType> types = common::TypesFromInputs(inputs);
+    form_structure.FillFields(
+        types,
+        compare,
+        get_info,
+        g_browser_process->GetApplicationLocale());

[Dan Beam, 2014/01/27 20:51:40]

nit:

  form_structure.FillFields(types,
                            compare,
                            get_info,
                            g_browser_process->GetApplicationLocale());

[Dan Beam, 2014/01/27 23:11:27]

this

[Evan Stade, 2014/01/28 00:07:59]

Done.

+  }
 }
 
 void FillOutputForSection(
     DialogSection section,
     FormStructure& form_structure,
-    wallet::FullWallet* full_wallet,
+    FullWallet* full_wallet,
     const base::string16& email_address) {
   DetailInputs inputs;
   common::BuildInputsForSection(section, "US", &inputs);
 
   FillOutputForSectionWithComparator(
       section, inputs,
       base::Bind(common::ServerTypeMatchesField, section),
       form_structure, full_wallet, email_address);
 
   if (section == SECTION_CC_BILLING) {
@@ skipping 140 matching lines @@
           form_structure_) ||
       IsSectionInputUsedInFormStructure(
           SECTION_SHIPPING,
           PHONE_HOME_WHOLE_NUMBER,
           form_structure_);
 
   bool request_shipping_address = false;
   {
     DetailInputs inputs;
     common::BuildInputsForSection(SECTION_SHIPPING, "US", &inputs);
-    EmptyDataModelWrapper empty_wrapper;
-    request_shipping_address = empty_wrapper.FillFormStructure(
-        inputs,
+    request_shipping_address = form_structure_.FillFields(
+        common::TypesFromInputs(inputs),
         base::Bind(common::ServerTypeMatchesField, SECTION_SHIPPING),
-        &form_structure_);
+        base::Bind(NullGetInfo),
+        g_browser_process->GetApplicationLocale());
   }
 
   const bool incognito_mode = profile_->IsOffTheRecord();
 
   bool last_used_choice_is_autofill = false;
   base::string16 last_used_account_name;
   std::string last_used_billing;
   std::string last_used_shipping;
   std::string last_used_credit_card;
   {
@@ skipping 76 matching lines @@
 
   const base::string16 last_used_account_name =
       base::android::ConvertJavaStringToUTF16(env, jlast_used_account_name);
   const std::string last_used_billing =
       base::android::ConvertJavaStringToUTF8(env, jlast_used_billing);
   const std::string last_used_shipping =
       base::android::ConvertJavaStringToUTF8(env, jlast_used_shipping);
   const std::string last_used_card =
       base::android::ConvertJavaStringToUTF8(env, jlast_used_card);
 
-  scoped_ptr<wallet::FullWallet> full_wallet =
+  scoped_ptr<FullWallet> full_wallet =
       AutofillDialogResult::ConvertFromJava(env, wallet);
   FillOutputForSection(
       SECTION_CC_BILLING, form_structure_, full_wallet.get(), email);
   FillOutputForSection(
       SECTION_SHIPPING, form_structure_, full_wallet.get(), email);

[Dan Beam, 2014/01/27 20:51:40]

where is "Use billing for shipping" on Android implemented?

 
   {
     DictionaryPrefUpdate updater(profile_->GetPrefs(),
                                  ::prefs::kAutofillDialogDefaults);
     base::DictionaryValue* defaults = updater.Get();
     if (defaults) {
       const bool last_used_choice_is_autofill = !!jlast_used_choice_is_autofill;
       defaults->SetString(kLastUsedAccountName, last_used_account_name);
       defaults->SetBoolean(kLastUsedChoiceIsAutofill,
                            last_used_choice_is_autofill);
@@ skipping 45 matching lines @@
 
 void AutofillDialogControllerAndroid::LogOnCancelMetrics() {
   GetMetricLogger().LogDialogUiDuration(
       base::Time::Now() - dialog_shown_timestamp_,
       AutofillMetrics::DIALOG_CANCELED);
 
   GetMetricLogger().LogDialogUiEvent(AutofillMetrics::DIALOG_UI_CANCELED);
 }
 
 }  // namespace autofill