chromeos: Stop directly downloading files to the cache directory from DriveFileSystem::GetResolvedF…

chromeos: Stop directly downloading files to the cache directory from DriveFileSystem::GetResolvedFile

Stop directly downloading files to cache directory, create temporary file instead.
Always free disk space from DriveCache::Store, regardless of the file operation type.

BUG=160487
TEST=unit_tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193007

[kinaba, 2013-04-08 09:18:54]

lgtm

[hidehiko, 2013-04-08 09:28:10]

lgtm

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_file_system.cc (right):

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system.cc:1049: DriveFileError error) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
to follow other methods?

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system.cc:1075: if (error !=
DRIVE_FILE_OK) {
ditto.

[hashimoto, 2013-04-08 10:39:24]

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_file_system.cc (right):

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system.cc:1049: DriveFileError error) {
On 2013/04/08 09:28:10, hidehiko wrote:
> DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
> to follow other methods?

Done.

https://codereview.chromium.org/13772005/diff/5/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_file_system.cc:1075: if (error !=
DRIVE_FILE_OK) {
On 2013/04/08 09:28:10, hidehiko wrote:
> ditto.

Done.

[commit-bot: I haz the power, 2013-04-08 10:57:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13772005/7001

[commit-bot: I haz the power, 2013-04-08 11:00:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-09 00:34:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13772005/7001

[commit-bot: I haz the power, 2013-04-09 04:37:51]

Change committed as 193007