Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1377173005: Make sure fast-path scrolls bubble on non-scrollable guest. (Closed)

Created:
5 years, 2 months ago by wjmaclean
Modified:
5 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure fast-path scrolls bubble on non-scrollable guest. Fast-path scrolling on a document with no ability to scroll generates event acks of INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS, which at present the RenderWidgetHostViewGuest::{Gesture|Wheel}EventAck() methods don't recognize. This CL enables forwarding for "no consumer exists" events. Existing tests are extended to test against both cases: guests that are and are not scrollable. BUG=491940 Committed: https://crrev.com/ab64ac02df18faa4cf307bd21ddec6b628f79ace Cr-Commit-Position: refs/heads/master@{#351795}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -5 lines) Patch
M chrome/browser/apps/guest_view/web_view_browsertest.cc View 1 4 chunks +31 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.js View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377173005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377173005/1
5 years, 2 months ago (2015-09-30 19:44:30 UTC) #3
wjmaclean
kenrb@ - Can you please do a pre-review, particular attention to RenderWidgetHostViewGuest code? (** small ...
5 years, 2 months ago (2015-09-30 19:45:17 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/89743) win_chromium_rel_ng on ...
5 years, 2 months ago (2015-09-30 19:50:51 UTC) #6
kenrb
This looks fine.
5 years, 2 months ago (2015-09-30 19:58:29 UTC) #7
wjmaclean
creis@ - please take a look when you get a moment? Thanks!
5 years, 2 months ago (2015-09-30 20:07:48 UTC) #8
Charlie Reis
I think I'll let Nick review this one for owners, since I really don't know ...
5 years, 2 months ago (2015-09-30 21:20:24 UTC) #10
ncarter (slow)
lgtm https://codereview.chromium.org/1377173005/diff/1/chrome/browser/apps/guest_view/web_view_browsertest.cc File chrome/browser/apps/guest_view/web_view_browsertest.cc (right): https://codereview.chromium.org/1377173005/diff/1/chrome/browser/apps/guest_view/web_view_browsertest.cc#newcode2560 chrome/browser/apps/guest_view/web_view_browsertest.cc:2560: // Create two test instances, one where theguest ...
5 years, 2 months ago (2015-09-30 21:37:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377173005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377173005/20001
5 years, 2 months ago (2015-10-01 12:49:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 14:29:31 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 14:31:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab64ac02df18faa4cf307bd21ddec6b628f79ace
Cr-Commit-Position: refs/heads/master@{#351795}

Powered by Google App Engine
This is Rietveld 408576698