Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 13771005: Files.app: Separate the last search query from "lastQuery" (Closed)

Created:
7 years, 8 months ago by yoshiki
Modified:
7 years, 8 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Separate the last search query from "lastQuery" The last SEARCH query and the last AUTO-COMPLETE query are different. But they were used as the single variable. This confusion caused the issue that sometimes the search result didn't disappear when the textbox was changed. This patch fixes the problem. BUG=225959 TEST=none NOTRY=True # for trybots seems broken. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192806

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@mtomasz: could you take a look? Thanks
7 years, 8 months ago (2013-04-08 06:47:37 UTC) #1
mtomasz
lgtm with a nit. https://codereview.chromium.org/13771005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/13771005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3108 chrome/browser/resources/file_manager/js/file_manager.js:3108: * @param {function} onClearSearch Function ...
7 years, 8 months ago (2013-04-08 07:59:09 UTC) #2
yoshiki
Thanks! https://codereview.chromium.org/13771005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/13771005/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3108 chrome/browser/resources/file_manager/js/file_manager.js:3108: * @param {function} onClearSearch Function to be called ...
7 years, 8 months ago (2013-04-08 11:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/13771005/5001
7 years, 8 months ago (2013-04-08 11:56:41 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 12:04:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/13771005/5001
7 years, 8 months ago (2013-04-08 12:16:05 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 12:16:15 UTC) #7
Message was sent while issue was closed.
Change committed as 192806

Powered by Google App Engine
This is Rietveld 408576698