Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: newlib/libc/sys/nacl/Makefile.am

Issue 1377003003: Specify output explicitly for the .c.o compile rule (Closed) Base URL: https://chromium.googlesource.com/native_client/nacl-newlib.git@master
Patch Set: Add comment to Makefile.am Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | newlib/libc/sys/nacl/Makefile.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: newlib/libc/sys/nacl/Makefile.am
diff --git a/newlib/libc/sys/nacl/Makefile.am b/newlib/libc/sys/nacl/Makefile.am
index a5463bc0cb81212b5b18ab3593c997b531ac2a0d..c64be1ba0556b11a7ff4767f22505147d7547e10 100644
--- a/newlib/libc/sys/nacl/Makefile.am
+++ b/newlib/libc/sys/nacl/Makefile.am
@@ -12,6 +12,15 @@ lib_a_SOURCES = dummysys.c aeabi_atexit.c
lib_a_CCASFLAGS = $(AM_CCASFLAGS)
lib_a_CFLAGS = $(AM_CFLAGS)
+## The automatically generated .c.o rule in Makefile.in does not specify the
+## output file name even though upper level Makefile assumes that the output
+## filename is crt0.o. However, this breaks when the compiler does not use .o
+## extension for object files. Newer Automake already specifies the output
+## filename, but since Newlib does not currently build with newer
+## Autoconf/Automake versions, we need to override the rule manually.
+.c.o:
+ $(COMPILE) -c $< -o $@
+
all: crt0.o
ACLOCAL_AMFLAGS = -I ../../.. -I ../../../..
« no previous file with comments | « no previous file | newlib/libc/sys/nacl/Makefile.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698