Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 13770008: Fix dcheck on win aura shutdown, use CloseNow to close secondary widgets (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Fix dcheck on win aura shutdown, use CloseNow to close secondary widgets In preference to https://codereview.chromium.org/13699002/ As it's only the secondary widgets (not the Frame), it appears relatively safe to use CloseNow to avoid the closing animation. R=sky@chromium.org BUG=226716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192981

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/widget/native_widget_aura.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years, 8 months ago (2013-04-08 19:25:18 UTC) #1
sky
LGTM https://codereview.chromium.org/13770008/diff/1/ui/views/widget/native_widget_aura.cc File ui/views/widget/native_widget_aura.cc (right): https://codereview.chromium.org/13770008/diff/1/ui/views/widget/native_widget_aura.cc#newcode906 ui/views/widget/native_widget_aura.cc:906: widget->CloseNow(); Add a comment here as to why ...
7 years, 8 months ago (2013-04-08 19:52:05 UTC) #2
scottmg
On 2013/04/08 19:52:05, sky wrote: > LGTM > > https://codereview.chromium.org/13770008/diff/1/ui/views/widget/native_widget_aura.cc > File ui/views/widget/native_widget_aura.cc (right): > ...
7 years, 8 months ago (2013-04-08 20:49:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/13770008/9001
7 years, 8 months ago (2013-04-08 20:50:15 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 01:40:41 UTC) #5
Message was sent while issue was closed.
Change committed as 192981

Powered by Google App Engine
This is Rietveld 408576698