Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 1376783004: Android: Mark more classes as non-mobile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
index 27cf2e4046b374140e92b67f07e8b0e5a89d55c8..9438a7a360c22e0f125c1042e19b421278e42ed2 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
@@ -342,10 +342,10 @@ void ChromeBrowserMainExtraPartsMetrics::PostBrowserStart() {
gfx::Screen::GetNativeScreen()->AddObserver(this);
is_screen_observer_ = true;
-#if !defined(OS_ANDROID)
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
gab 2015/09/30 14:39:43 Does iOS even compile this file? I thought iOS did
Lei Zhang 2015/09/30 23:33:55 iOS still have not finished fully removing their c
first_web_contents_profiler_ =
Lei Zhang 2015/09/30 06:40:09 Already never created on mobile.
FirstWebContentsProfiler::CreateProfilerForFirstWebContents(this).Pass();
-#endif // !defined(OS_ANDROID)
+#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
}
void ChromeBrowserMainExtraPartsMetrics::OnDisplayAdded(
@@ -363,9 +363,11 @@ void ChromeBrowserMainExtraPartsMetrics::OnDisplayMetricsChanged(
uint32_t changed_metrics) {
}
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
void ChromeBrowserMainExtraPartsMetrics::ProfilerFinishedCollectingMetrics() {
first_web_contents_profiler_.reset();
}
+#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
void ChromeBrowserMainExtraPartsMetrics::EmitDisplaysChangedMetric() {
int display_count = gfx::Screen::GetNativeScreen()->GetNumDisplays();

Powered by Google App Engine
This is Rietveld 408576698