Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1376143002: Add a document phase for calculating paint properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase (remove GLB check, as was done in synchronizedPaint) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 0ac9a2b83253f07c93b5c44daff1e746881dddc2..d93de04405fa2e0c14f9eb4ef716e6007472d9fc 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2438,6 +2438,9 @@ void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases, cons
updateCompositedSelectionIfNeeded();
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+ calculatePaintProperties();
+
if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
synchronizedPaint(interestRect);
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
@@ -2455,6 +2458,15 @@ void FrameView::updateLifecyclePhasesInternal(LifeCycleUpdateOption phases, cons
}
}
+void FrameView::calculatePaintProperties()
esprehn 2015/10/01 09:05:07 recalcPaintProperties would match the verbage we u
+{
+ ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
+
+ lifecycle().advanceTo(DocumentLifecycle::InCalcPaintProps);
+ // TODO(pdr): Calculate the paint properties by walking the layout tree.
esprehn 2015/10/01 09:00:08 That design doc is very light on details, how will
+ lifecycle().advanceTo(DocumentLifecycle::CalcPaintPropsClean);
+}
+
void FrameView::synchronizedPaint(const LayoutRect& interestRect)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled());

Powered by Google App Engine
This is Rietveld 408576698