Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2192)

Unified Diff: components/autofill/browser/personal_data_manager_unittest.cc

Issue 13760005: Allows profile import from forms with 'confirm email' field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review revisions. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/browser/personal_data_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/browser/personal_data_manager_unittest.cc
diff --git a/components/autofill/browser/personal_data_manager_unittest.cc b/components/autofill/browser/personal_data_manager_unittest.cc
index fe4238cdeb4d39036643b6e5dff6cf28b81eb266..d7e10618509c4df9dd7a40f46d8d0412ca94bcfe 100644
--- a/components/autofill/browser/personal_data_manager_unittest.cc
+++ b/components/autofill/browser/personal_data_manager_unittest.cc
@@ -580,6 +580,74 @@ TEST_F(PersonalDataManagerTest, ImportFormDataBadEmail) {
ASSERT_EQ(0U, results.size());
}
+// Tests that a 'confirm email' field does not block profile import.
+TEST_F(PersonalDataManagerTest, ImportFormDataTwoEmails) {
+ FormData form;
+ FormFieldData field;
+ autofill_test::CreateTestFormField(
+ "Name:", "name", "George Washington", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Address:", "address1", "21 Laussat St", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "City:", "city", "San Francisco", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "State:", "state", "California", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Zip:", "zip", "94102", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Email:", "email", "example@example.com", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Confirm email:", "confirm_email", "example@example.com", "text", &field);
+ form.fields.push_back(field);
+ FormStructure form_structure(form, std::string());
+ form_structure.DetermineHeuristicTypes(TestAutofillMetrics());
+ const CreditCard* imported_credit_card;
+ EXPECT_TRUE(personal_data_->ImportFormData(form_structure,
+ &imported_credit_card));
+ const std::vector<AutofillProfile*>& results = personal_data_->GetProfiles();
+ ASSERT_EQ(1U, results.size());
+}
+
+// Tests two email fields containing different values blocks provile import.
+TEST_F(PersonalDataManagerTest, ImportFormDataTwoDifferentEmails) {
+ FormData form;
+ FormFieldData field;
+ autofill_test::CreateTestFormField(
+ "Name:", "name", "George Washington", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Address:", "address1", "21 Laussat St", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "City:", "city", "San Francisco", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "State:", "state", "California", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Zip:", "zip", "94102", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Email:", "email", "example@example.com", "text", &field);
+ form.fields.push_back(field);
+ autofill_test::CreateTestFormField(
+ "Email:", "email2", "example2@example.com", "text", &field);
+ form.fields.push_back(field);
+ FormStructure form_structure(form, std::string());
+ form_structure.DetermineHeuristicTypes(TestAutofillMetrics());
+ const CreditCard* imported_credit_card;
+ EXPECT_FALSE(personal_data_->ImportFormData(form_structure,
+ &imported_credit_card));
+ const std::vector<AutofillProfile*>& results = personal_data_->GetProfiles();
+ ASSERT_EQ(0U, results.size());
+}
+
TEST_F(PersonalDataManagerTest, ImportFormDataNotEnoughFilledFields) {
FormData form;
FormFieldData field;
« no previous file with comments | « components/autofill/browser/personal_data_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698