Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 13760005: Allows profile import from forms with 'confirm email' field (Closed)

Created:
7 years, 8 months ago by Jim Blackler
Modified:
7 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allows profile import from forms with 'confirm email' field Does this by adding EMAIL_ADDRESS to the list of fields excluded from the condition marked "abandon the import if two fields of the same type are encountered" in PersonalDataManager::IsValidFieldTypeAndValue() BUG=224364 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193335

Patch Set 1 #

Patch Set 2 : Review revisions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M components/autofill/browser/personal_data_manager.cc View 1 2 chunks +15 lines, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jim Blackler
7 years, 8 months ago (2013-04-07 09:42:31 UTC) #1
Ilya Sherman
Please add a test case to make sure the import fails if two different email ...
7 years, 8 months ago (2013-04-07 22:42:01 UTC) #2
Jim Blackler
On 2013/04/07 22:42:01, Ilya Sherman wrote: > Please add a test case to make sure ...
7 years, 8 months ago (2013-04-09 14:33:52 UTC) #3
Ilya Sherman
LGTM, thanks
7 years, 8 months ago (2013-04-10 04:43:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jimblackler@chromium.org/13760005/5001
7 years, 8 months ago (2013-04-10 04:43:41 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 06:31:25 UTC) #6
Message was sent while issue was closed.
Change committed as 193335

Powered by Google App Engine
This is Rietveld 408576698