Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: ui/views/controls/textfield/native_textfield_views.cc

Issue 13759002: Silence Views Textfield OnInputMethodChanged NOTIMPLEMENTED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/textfield/native_textfield_views.h" 5 #include "ui/views/controls/textfield/native_textfield_views.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 992 matching lines...) Expand 10 before | Expand all | Expand 10 after
1003 1003
1004 ui::Range text_range; 1004 ui::Range text_range;
1005 if (!GetTextRange(&text_range) || !text_range.Contains(range)) 1005 if (!GetTextRange(&text_range) || !text_range.Contains(range))
1006 return false; 1006 return false;
1007 1007
1008 *text = model_->GetTextFromRange(range); 1008 *text = model_->GetTextFromRange(range);
1009 return true; 1009 return true;
1010 } 1010 }
1011 1011
1012 void NativeTextfieldViews::OnInputMethodChanged() { 1012 void NativeTextfieldViews::OnInputMethodChanged() {
1013 NOTIMPLEMENTED(); 1013 // TODO(msw): NOTIMPLEMENTED(); see http://crbug.com/140402
1014 } 1014 }
1015 1015
1016 bool NativeTextfieldViews::ChangeTextDirectionAndLayoutAlignment( 1016 bool NativeTextfieldViews::ChangeTextDirectionAndLayoutAlignment(
1017 base::i18n::TextDirection direction) { 1017 base::i18n::TextDirection direction) {
1018 NOTIMPLEMENTED(); 1018 NOTIMPLEMENTED();
1019 return false; 1019 return false;
1020 } 1020 }
1021 1021
1022 void NativeTextfieldViews::ExtendSelectionAndDelete( 1022 void NativeTextfieldViews::ExtendSelectionAndDelete(
1023 size_t before, 1023 size_t before,
(...skipping 381 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 1405
1406 void NativeTextfieldViews::PlatformGestureEventHandling( 1406 void NativeTextfieldViews::PlatformGestureEventHandling(
1407 const ui::GestureEvent* event) { 1407 const ui::GestureEvent* event) {
1408 #if defined(OS_WIN) && defined(USE_AURA) 1408 #if defined(OS_WIN) && defined(USE_AURA)
1409 if (event->type() == ui::ET_GESTURE_TAP_DOWN && !textfield_->read_only()) 1409 if (event->type() == ui::ET_GESTURE_TAP_DOWN && !textfield_->read_only())
1410 base::win::DisplayVirtualKeyboard(); 1410 base::win::DisplayVirtualKeyboard();
1411 #endif 1411 #endif
1412 } 1412 }
1413 1413
1414 } // namespace views 1414 } // namespace views
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698