Fix dropping images into content editable divs.

Fix dropping images into content editable divs.

Mail.app and TextEdit accept drags that have both HTML and image flavors on them, but don't process them correctly. Therefore,
if there is an image flavor, don't put the HTML data on as HTML, but rather put it on as a special flavor. External apps won't see HTML but Chrome will know enough to read it as HTML.

BUG=55879, 225710
TEST=as in bug 225710, doesn't regress bug 55879

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192853

[Avi (use Gerrit), 2013-04-07 00:34:03]

Nico:

Do you remember https://chromiumcodereview.appspot.com/11666018 ? Yes? That
broke things hard. Time to hack it harder.

[Avi (use Gerrit), 2013-04-07 00:34:16]

I'm truly sorry for this CL.

[Nico, 2013-04-08 16:37:00]

lgtm

Please expand the CL description to make it describe what this CL does, and why
(you can just copy the header file comment for kChromeDragImageHTMLPboardType to
the Cl description I think, as that's a good summary.)

I think this is probably the best we can do given the constraints. It might
break copy-pasting content editable html from chromium to safari or firefox (?)

[Avi (use Gerrit), 2013-04-08 16:50:25]

On 2013/04/08 16:37:00, Nico wrote:
> Please expand the CL description to make it describe what this CL does, and
why

OK.

> I think this is probably the best we can do given the constraints. It might
> break copy-pasting content editable html from chromium to safari or firefox
(?)

It can't break it from Safari since Safari puts WebArchive flavors on the
pasteboard, not HTML, and we can't read those. As for Firefox... yeah, sorry.
Those were already broken by my previous CL.

[commit-bot: I haz the power, 2013-04-08 16:51:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/13758002/1

[commit-bot: I haz the power, 2013-04-08 17:00:20]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 17:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/13758002/1

[commit-bot: I haz the power, 2013-04-08 18:53:16]

Change committed as 192853

[andruid, 2013-04-08 19:25:28]

It's up to the application to use all the data flavors.

Do not hide the HTML if there is an image. That is awful!!!

It also violates the HTML 5 spec.

Thanks!

Andruid Kerne
Interface Ecology Lab @ Texas A&m