Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart

Issue 1375313004: Always include Object and its members into 'inherited'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
diff --git a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
index 0891156c34ddf4e5c8b95029a0249dd7b600f963..f96f42f2b21774dc8d367ecaa129abe52d2f3980 100644
--- a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
+++ b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
@@ -22,6 +22,15 @@ class ImplementedComputer {
compute() async {
for (ClassElement type in unitElement.types) {
+ // always include Object and its members
+ if (type.supertype == null) {
+ _addImplementedClass(type);
+ type.accessors.forEach(_addImplementedMember);
+ type.fields.forEach(_addImplementedMember);
+ type.methods.forEach(_addImplementedMember);
+ continue;
+ }
+ // analyze ancestors
subtypes = await getSubClasses(searchEngine, type);
if (subtypes.isNotEmpty) {
_addImplementedClass(type);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698