Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1374843004: Isolate ui_touch_selection_unittests. (Closed)

Created:
5 years, 2 months ago by ghost stip (do not use)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate ui_touch_selection_unittests. BUG=525873 Committed: https://crrev.com/4c3497591aba5d15f8f0caee9aca2b98d53ed955 Cr-Commit-Position: refs/heads/master@{#353873}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M ui/touch_selection/ui_touch_selection.gyp View 1 1 chunk +20 lines, -1 line 0 comments Download
A + ui/touch_selection/ui_touch_selection_unittests_apk.isolate View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
ghost stip (do not use)
maruel/jbudorick: review jdduke: OWNERS
5 years, 2 months ago (2015-09-29 18:11:20 UTC) #2
jbudorick
https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode135 ui/touch_selection/ui_touch_selection.gyp:135: 'target_name': 'ui_touch_selection_unittests_run', Do we want this to build on ...
5 years, 2 months ago (2015-09-29 18:14:38 UTC) #3
jdduke (slow)
What about GN? https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode159 ui/touch_selection/ui_touch_selection.gyp:159: 'target_name': 'ui_touch_selection_unittests_apk_run', Are we doing this ...
5 years, 2 months ago (2015-09-29 18:25:48 UTC) #4
ghost stip (do not use)
https://chromiumcodereview.appspot.com/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://chromiumcodereview.appspot.com/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode135 ui/touch_selection/ui_touch_selection.gyp:135: 'target_name': 'ui_touch_selection_unittests_run', On 2015/09/29 18:14:38, jbudorick wrote: > Do ...
5 years, 2 months ago (2015-09-29 21:50:09 UTC) #5
jbudorick
https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode135 ui/touch_selection/ui_touch_selection.gyp:135: 'target_name': 'ui_touch_selection_unittests_run', On 2015/09/29 at 21:50:09, stip wrote: > ...
5 years, 2 months ago (2015-09-30 08:49:41 UTC) #6
ghost stip (do not use)
ptal https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1374843004/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode135 ui/touch_selection/ui_touch_selection.gyp:135: 'target_name': 'ui_touch_selection_unittests_run', On 2015/09/30 08:49:41, jbudorick wrote: > ...
5 years, 2 months ago (2015-10-13 06:39:20 UTC) #7
jbudorick
lgtm
5 years, 2 months ago (2015-10-13 13:09:46 UTC) #8
jdduke (slow)
rubberstamp lgtm
5 years, 2 months ago (2015-10-13 21:05:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374843004/20001
5 years, 2 months ago (2015-10-13 21:11:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 22:23:35 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:24:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c3497591aba5d15f8f0caee9aca2b98d53ed955
Cr-Commit-Position: refs/heads/master@{#353873}

Powered by Google App Engine
This is Rietveld 408576698