Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 13736002: Do not sudo unless necessary. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/swarm_client.git@master
Visibility:
Public.

Description

Do not sudo unless necessary. This makes it easier to run the swarm_client smoke tests on insecure systems. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M trace_inputs.py View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-05 17:35:20 UTC) #1
csharp
lgtm
7 years, 8 months ago (2013-04-05 17:54:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13736002/1
7 years, 8 months ago (2013-04-05 17:59:55 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 18:01:04 UTC) #4
Message was sent while issue was closed.
Change committed as 192600

Powered by Google App Engine
This is Rietveld 408576698