Make sure official GN builds on Linux have debug info.

Make sure official GN builds on Linux have debug info.

On all platforms, we want the official builds to have
debug info so that we can get sensible stack traces. On non-Linux platforms, this was already the case, since the default is to contain symbols, but on Linux, we had a special case where non-debug builds did not have symbols.

This patches fixes that so that only non-debug, non-official Linux bugs do not have symbols.

R=brettw@chromium.org
BUG=530733
Committed: https://crrev.com/7f637b47a3b5a83a5447c0b3dee1fb0bc3e979ce
Cr-Commit-Position: refs/heads/master@{#351686}

[Dirk Pranke, 2015-09-29 21:01:13]

previously they did not.

[Dirk Pranke, 2015-09-29 21:06:58]

updated CL description to give more background; my previous email comment will
now not make any sense :).

[brettw, 2015-09-29 21:12:29]

lgtm

https://codereview.chromium.org/1373323002/diff/1/build/config/compiler/compi...
File build/config/compiler/compiler.gni (right):

https://codereview.chromium.org/1373323002/diff/1/build/config/compiler/compi...
build/config/compiler/compiler.gni:23: if (is_debug || !is_linux ||
is_official_build)) {
Theoretically this needs //build/config/chrome_build.gni imported. Maybe it
works because this was already imported by somebody else?

[Dirk Pranke, 2015-10-01 00:15:46]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-10-01 00:15:46]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1373323002/#ps20001
(title: "add chrome_build.gni import")

[commit-bot: I haz the power, 2015-10-01 00:17:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373323002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373323002/20001

[commit-bot: I haz the power, 2015-10-01 00:48:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-01 00:49:44]

Patchset 2 (id:??) landed as
https://crrev.com/7f637b47a3b5a83a5447c0b3dee1fb0bc3e979ce
Cr-Commit-Position: refs/heads/master@{#351686}