Issue 13730015: Misc improvements to drover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13730015: Misc improvements to drover (Closed)

Created:
7 years, 8 months ago by Isaac (away)

Modified:
7 years, 8 months ago

Reviewers:
laforge, Dirk Pranke, laforge

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Misc improvements to drover - Improve SVN heuristic by using cutoff of 180 days instead of 120. I've verified this won't cause problems with the repos we use. (the closest is blink ToT and chrome, blink ToT refers to a revision in chrome from 9 months ago) - Alert if using local drover.properties file. Webkit devs had a drover.properties file that hardcodes svn.webkit.org, which makes drover point to the wrong revision. BUG=227168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192641

Patch Set 1 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	drover.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/13730015/2001

7 years, 8 months ago (2013-04-05 22:41:03 UTC) #3

Message was sent while issue was closed.

Change committed as 192641

Expand Messages | Collapse Messages