Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: chrome/app/theme/README

Issue 1372843002: optimize-ico-files: Automatically rebuild the AND mask of 32-bit images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added link to bug. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/resources/optimize-ico-files.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/theme/README
diff --git a/chrome/app/theme/README b/chrome/app/theme/README
index 6a0438c208279d5b1d855c15d7e2425db9b48263..ff029c72a1ebd2f313867895e5d4f3b563753a9a 100644
--- a/chrome/app/theme/README
+++ b/chrome/app/theme/README
@@ -24,11 +24,6 @@ Windows ICO icons should be in the following format:
If you are creating an ICO from a set of PNGs of different sizes, the following
process (using ImageMagick and GIMP) satisfies the above conditions:
-**IMPORTANT**: There is an issue with GIMP generating sub-optimal ICO files
-(see http://crbug.com/526622#c35); therefore if you are creating or updating
-icons using the below process, please add mgiuca@chromium.org as a reviewer.
-TODO(mgiuca): Update the tools/process to work around the problem.
-
1. Convert each of the smaller images to 8-bit. With ImageMagick:
for f in FILENAME-??.png; \
@@ -46,4 +41,5 @@ TODO(mgiuca): Update the tools/process to work around the problem.
4. Run src/tools/resources/optimize-ico-files.py on the resulting .ico file.
You can also run src/tools/resources/optimize-ico-files.py on existing .ico
-files. This will run a basic PNG optimization pass.
+files. This will run a basic PNG optimization pass and fix up any broken image
+masks (http://crbug.com/534679).
« no previous file with comments | « no previous file | tools/resources/optimize-ico-files.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698