Start caching tinting ColorStateLists in Toolbar.

Start caching tinting ColorStateLists in Toolbar.

BUG=535235
Committed: https://crrev.com/9792701d623f7502cb547e8b7d696279fbd957ba
Cr-Commit-Position: refs/heads/master@{#351400}

[aurimas (slooooooooow), 2015-09-25 18:39:18]

aurimas@chromium.org changed reviewers:
+ yusufo@chromium.org

[aurimas (slooooooooow), 2015-09-25 18:39:18]

PTAL

[Yusuf, 2015-09-25 18:51:40]

Wohoo!

Now if you search for light_mode_tint in ToolbarPhone and also get rid of the
case where we get these as a color (not ColorStateList) and use the cached
values somehow (not sure about ColorStateList Color conversion), then this would
be an awesome change.

[aurimas (slooooooooow), 2015-09-25 21:44:55]

Please take another look

[Yusuf, 2015-09-28 17:20:27]

https://chromiumcodereview.appspot.com/1372653002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(left):

https://chromiumcodereview.appspot.com/1372653002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1873:
mUseLightToolbarDrawables ? white : dark);
setTint(int color) is API 21+. There is a DrawableCompat.setTint(Drawable, int)
which seems useful for our purposes as well. Wonder what is different between
that and our own TintedDrawable.

[aurimas (slooooooooow), 2015-09-28 20:32:56]

https://chromiumcodereview.appspot.com/1372653002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(left):

https://chromiumcodereview.appspot.com/1372653002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1873:
mUseLightToolbarDrawables ? white : dark);
On 2015/09/28 at 17:20:26, Yusuf wrote:
> setTint(int color) is API 21+. There is a DrawableCompat.setTint(Drawable,
int) which seems useful for our purposes as well. Wonder what is different
between that and our own TintedDrawable.

Filed a bug for investigating that crbug.com/536920

[Yusuf, 2015-09-29 06:01:40]

lgtm

[aurimas (slooooooooow), 2015-09-29 15:38:20]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-09-29 15:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372653002/20001

[commit-bot: I haz the power, 2015-09-29 15:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 15:40:20]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aurimas (slooooooooow), 2015-09-29 18:38:11]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-09-29 18:38:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1372653002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-29 18:38:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372653002/40001

[commit-bot: I haz the power, 2015-09-29 19:05:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 19:05:13]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[aurimas (slooooooooow), 2015-09-29 20:47:15]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-09-29 20:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372653002/40001

[commit-bot: I haz the power, 2015-09-29 21:10:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-29 21:11:37]

Patchset 3 (id:??) landed as
https://crrev.com/9792701d623f7502cb547e8b7d696279fbd957ba
Cr-Commit-Position: refs/heads/master@{#351400}