Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4829)

Unified Diff: chrome/renderer/resources/extensions/miscellaneous_bindings.js

Issue 13726026: Added ActivityLog tests and associated bugfixes/extra logging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wrapped line Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/miscellaneous_bindings.js
diff --git a/chrome/renderer/resources/extensions/miscellaneous_bindings.js b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
index 59f07de0d6802ee446e457af1fef4c8b723ffc3f..33eb9d96f8620a987823bdbb2f49dbcff08af62c 100644
--- a/chrome/renderer/resources/extensions/miscellaneous_bindings.js
+++ b/chrome/renderer/resources/extensions/miscellaneous_bindings.js
@@ -24,6 +24,8 @@
var manifestVersion = processNatives.GetManifestVersion();
var extensionId = processNatives.GetExtensionId();
+ var logActivity = requireNative('activityLogger');
+
// The reserved channel name for the sendRequest/sendMessage APIs.
// Note: sendRequest is deprecated.
chromeHidden.kRequestChannel = "chrome.extension.sendRequest";
@@ -173,6 +175,14 @@
}
}
});
+ var eventName = (isSendMessage ?
+ (isExternal ?
+ "runtime.onMessageExternal" : "runtime.onMessage") :
+ (isExternal ?
+ "extension.onRequestExternal" : "extension.onRequest"));
+ logActivity.LogEvent(targetExtensionId,
+ eventName,
+ [sourceExtensionId]);
return true;
}
return false;
@@ -215,7 +225,12 @@
if (manifestVersion < 2)
port.tab = port.sender.tab;
+ var eventName = (isExternal ?
+ "runtime.onConnectExternal" : "runtime.onConnect");
connectEvent.dispatch(port);
+ logActivity.LogEvent(targetExtensionId,
+ eventName,
+ [sourceExtensionId]);
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698