Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 13726021: Change PPB_VideoWriter Open function to return stream_id as out param. (Closed)

Created:
7 years, 8 months ago by bbudge
Modified:
7 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, raymes+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Change PPB_VideoWriter Open function to return stream_id as out param. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M ppapi/api/ppb_video_writer.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/c/ppb_video_writer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/cpp/video_reader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/cpp/video_reader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/cpp/video_writer.h View 1 chunk +4 lines, -5 lines 0 comments Download
M ppapi/cpp/video_writer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
bbudge
Minor tweak to PPB_VideoWriter Open method. The host should generate the stream_id. This forced me ...
7 years, 8 months ago (2013-04-05 22:54:37 UTC) #1
juberti
On 2013/04/05 22:54:37, bbudge1 wrote: > Minor tweak to PPB_VideoWriter Open method. The host should ...
7 years, 8 months ago (2013-04-05 23:38:56 UTC) #2
bbudge
Improved VideoWriter wrapper's Var out param. No need for TCCWO.
7 years, 8 months ago (2013-04-06 00:55:14 UTC) #3
bbudge
Improved VideoWriter wrapper's Var out param. No need for TCCWO.
7 years, 8 months ago (2013-04-06 00:55:15 UTC) #4
juberti
On 2013/04/06 00:55:15, bbudge1 wrote: > Improved VideoWriter wrapper's Var out param. No need for ...
7 years, 8 months ago (2013-04-06 02:03:29 UTC) #5
bbudge
On 2013/04/06 02:03:29, juberti wrote: > On 2013/04/06 00:55:15, bbudge1 wrote: > > Improved VideoWriter ...
7 years, 8 months ago (2013-04-07 19:00:14 UTC) #6
dmichael (off chromium)
lgtm
7 years, 8 months ago (2013-04-08 17:12:24 UTC) #7
juberti
On 2013/04/08 17:12:24, dmichael wrote: > lgtm lgtm
7 years, 8 months ago (2013-04-08 17:21:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/13726021/1
7 years, 8 months ago (2013-04-08 17:39:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=115957
7 years, 8 months ago (2013-04-08 19:23:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/13726021/1
7 years, 8 months ago (2013-04-08 19:29:32 UTC) #11
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 20:38:33 UTC) #12
Message was sent while issue was closed.
Change committed as 192883

Powered by Google App Engine
This is Rietveld 408576698