Issue 13726019: Instant Extended: Hide bookmark bar on search results page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13726019: Instant Extended: Hide bookmark bar on search results page (Closed)

Created:
7 years, 8 months ago by sail

Modified:
7 years, 8 months ago

Reviewers:
kuan, dhollowa

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Instant Extended: Hide bookmark bar on search results page When on a search results page the bookmark bar should be shown. This was a regression from r189607. Fix was to hide the bookmark bar in MODE_SEARCH_RESULTS as well as MODE_SEARCH_SUGGESTIONS. BUG=225767 TEST= Added a regression test, BrowserWindowControllerTest.InstantSearchResultsMode. Ran Chrome in instant extended mode. Did a search and clicked on the results page. Verified that the bookmark bar stayed hidden. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192680

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/13726019/1

7 years, 8 months ago (2013-04-05 21:11:14 UTC) #3

Message was sent while issue was closed.

Change committed as 192680

Expand Messages | Collapse Messages