Issue 13725015: Merge ui::Layer's concept of position with cc::Layer's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13725015: Merge ui::Layer's concept of position with cc::Layer's (Closed)

Created:
7 years, 8 months ago by ajuma

Modified:
7 years, 8 months ago

Reviewers:
piman

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, cc-bugs_chromium.org, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge ui::Layer's concept of position with cc::Layer's This makes ui::Layer use cc::Layer::SetPosition for setting its position, instead of baking its position into the transform that's set on the cc::Layer. This means that a change to a ui::Layer's bounds no longer affects the transform set on the cc::Layer, and hence bounds animations no longer conflict with threaded transform animations. BUG=170219, 226326 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192659

Patch Set 1 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -22 lines)			Patch
M	ui/compositor/layer.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	ui/compositor/layer.cc	View	6 chunks	+11 lines, -6 lines	0 comments	Download
M	ui/compositor/layer_animation_element.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/compositor/layer_animation_sequence.cc	View	1 chunk	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/13725015/2001

7 years, 8 months ago (2013-04-05 19:32:31 UTC) #3

Message was sent while issue was closed.

Change committed as 192659

Expand Messages | Collapse Messages