Issue 13724008: History: Fix alignment issue with 'x' buttons on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13724008: History: Fix alignment issue with 'x' buttons on Android. (Closed)

Created:
7 years, 8 months ago by Patrick Dubroy

Modified:
7 years, 8 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

History: Fix alignment issue with 'x' buttons on Android. Sergiu's fix for crbug.com/224081 inadvertently broke the layout on Android. This fixes the problem. BUG=None TEST=Open chrome://history and ensure that the 'x' buttons on the right hand side of each entry are all aligned. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192619

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/history/history_mobile.css	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/13724008/1

7 years, 8 months ago (2013-04-05 19:19:25 UTC) #3

Message was sent while issue was closed.

Change committed as 192619

Expand Messages | Collapse Messages