Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 13722014: linux_aura: Ask the NativeTheme for various colors which were hardcoded. (Closed)

Created:
7 years, 8 months ago by Elliot Glaysher
Modified:
7 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su
Visibility:
Public.

Description

linux_aura: Ask the NativeTheme for various colors which were hardcoded. This makes text in the omnibox dropdown visible again on linux_aura. BUG=130810 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192690

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +6 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
7 years, 8 months ago (2013-04-05 21:26:29 UTC) #1
sky
LGTM https://codereview.chromium.org/13722014/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/13722014/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode162 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:162: colors[NORMAL][BACKGROUND] = theme->GetSystemColor( Won't this clobber the values ...
7 years, 8 months ago (2013-04-05 23:05:52 UTC) #2
Elliot Glaysher
https://codereview.chromium.org/13722014/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc File chrome/browser/ui/views/omnibox/omnibox_result_view.cc (right): https://codereview.chromium.org/13722014/diff/1/chrome/browser/ui/views/omnibox/omnibox_result_view.cc#newcode162 chrome/browser/ui/views/omnibox/omnibox_result_view.cc:162: colors[NORMAL][BACKGROUND] = theme->GetSystemColor( On 2013/04/05 23:05:52, sky wrote: > ...
7 years, 8 months ago (2013-04-05 23:07:52 UTC) #3
sky
Ya, sorry. I wrote that first and forgot to remove the comment. That's why I ...
7 years, 8 months ago (2013-04-05 23:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/13722014/1
7 years, 8 months ago (2013-04-05 23:18:07 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 01:46:41 UTC) #6
Message was sent while issue was closed.
Change committed as 192690

Powered by Google App Engine
This is Rietveld 408576698