Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 13722009: Disable 'Create Shortcut' menu item on Mac. (Closed)

Created:
7 years, 8 months ago by jeremya
Modified:
7 years, 8 months ago
Reviewers:
benwells, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Disable 'Create Shortcut' menu item on Mac. This isn't ready for public use yet, so disable the UI. BUG=138733 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/ntp4/apps_page.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jeremya
I plan to merge this back to M27 to disable it there, too.
7 years, 8 months ago (2013-04-05 19:49:30 UTC) #1
Evan Stade
lgtm
7 years, 8 months ago (2013-04-06 00:15:41 UTC) #2
benwells
lgtm
7 years, 8 months ago (2013-04-08 06:02:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/13722009/1
7 years, 8 months ago (2013-04-08 16:39:50 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 16:47:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/13722009/1
7 years, 8 months ago (2013-04-08 18:12:36 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=115987
7 years, 8 months ago (2013-04-08 19:57:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/13722009/1
7 years, 8 months ago (2013-04-08 20:38:41 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 21:27:41 UTC) #9
Message was sent while issue was closed.
Change committed as 192903

Powered by Google App Engine
This is Rietveld 408576698