Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 13722005: Moves fields only accessed from content::DocumentState to content::InternalDocumentStateData. (Closed)

Created:
7 years, 8 months ago by sky
Modified:
7 years, 5 months ago
Reviewers:
jam, Dan Beam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Moves fields only accessed from content::DocumentState to content::InternalDocumentStateData. BUG=none TEST=none (cleanup). R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193107

Patch Set 1 #

Patch Set 2 : Style tweak #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -192 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/document_state.h View 7 chunks +0 lines, -104 lines 0 comments Download
M content/public/renderer/document_state.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/internal_document_state_data.h View 3 chunks +100 lines, -0 lines 0 comments Download
M content/renderer/internal_document_state_data.cc View 3 chunks +26 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 21 chunks +62 lines, -69 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
sky
7 years, 8 months ago (2013-04-05 19:26:00 UTC) #1
sky
https://codereview.chromium.org/13722005/diff/2001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (left): https://codereview.chromium.org/13722005/diff/2001/content/renderer/render_view_impl.cc#oldcode1628 content/renderer/render_view_impl.cc:1628: if (!document_state->security_info().empty()) { I removed scurity_info entirely as it ...
7 years, 8 months ago (2013-04-08 16:53:48 UTC) #2
jam
lgtm, thanks
7 years, 8 months ago (2013-04-09 00:14:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/13722005/2001
7 years, 8 months ago (2013-04-09 00:17:13 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-09 01:02:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/13722005/2001
7 years, 8 months ago (2013-04-09 13:39:21 UTC) #6
commit-bot: I haz the power
Change committed as 193107
7 years, 8 months ago (2013-04-09 15:28:39 UTC) #7
Dan Beam
7 years, 5 months ago (2013-07-03 17:44:36 UTC) #8
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/13722005/diff/2001/content/renderer/re...
File content/renderer/render_view_impl.cc (right):

https://chromiumcodereview.appspot.com/13722005/diff/2001/content/renderer/re...
content/renderer/render_view_impl.cc:2835: return SSLStatus();
what is the point of this method now?

Powered by Google App Engine
This is Rietveld 408576698