Issue 13713002: ImageFamily: Renamed Get method to GetBest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13713002: ImageFamily: Renamed Get method to GetBest. (Closed)

Created:
7 years, 8 months ago by Matt Giuca

Modified:
7 years, 8 months ago

Reviewers:
Robert Sesek, benwells

CC:
chromium-reviews, rsesek+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

ImageFamily: Renamed Get method to GetBest. This is a better description of the operation, since it is fuzzy rather than a direct lookup. BUG=189137 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192689

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -43 lines)			Patch
M	ui/gfx/image/image_family.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_family.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/image/image_family_unittest.cc	View	2 chunks	+41 lines, -41 lines	0 comments	Download

Total messages: 5 (0 generated)

Matt Giuca

Hi, Ben and I just decided that it was less confusing (from the caller's perspective) ...

7 years, 8 months ago (2013-04-05 06:39:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/13713002/1

7 years, 8 months ago (2013-04-05 23:52:52 UTC) #4

Message was sent while issue was closed.

Change committed as 192689