Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: Source/core/rendering/RootInlineBox.cpp

Issue 137123009: Add hittest mode for Touch-action which ignore inline elements and svg elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RootInlineBox.cpp
diff --git a/Source/core/rendering/RootInlineBox.cpp b/Source/core/rendering/RootInlineBox.cpp
old mode 100644
new mode 100755
index 0d95cafe0447ab41f6310ad8046df058f3318654..15bb91cfb4c7f1bc1ae3bc6b3143135a30728273
--- a/Source/core/rendering/RootInlineBox.cpp
+++ b/Source/core/rendering/RootInlineBox.cpp
@@ -177,6 +177,8 @@ void RootInlineBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset,
bool RootInlineBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom)
{
+ if (request.touchAction())
Rick Byers 2014/01/17 16:12:46 Does this need to be on a inline-box by inline-box
gnana 2014/01/21 14:00:16 Ok. i will apply Opt-in way.
Rick Byers 2014/01/21 15:24:20 This might be OK. We'd probably need to look at e
leviw_travelin_and_unemployed 2014/01/21 19:15:00 Generally speaking, I agree that what you really w
+ return false;
if (hasEllipsisBox() && visibleToHitTestRequest(request)) {
if (ellipsisBox()->nodeAtPoint(request, result, locationInContainer, accumulatedOffset, lineTop, lineBottom)) {
renderer()->updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));

Powered by Google App Engine
This is Rietveld 408576698