Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 13704002: Minor Native Client specific changes to files in src. (Closed)

Created:
7 years, 8 months ago by Brad Chen
Modified:
7 years, 8 months ago
Reviewers:
ulan, danno
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Minor Native Client specific changes to files in src. These changes are required for Native Client validation and to accomodate the limitations of the NaCl runtime. BUG=2614 Committed: https://code.google.com/p/v8/source/detail?r=14187

Patch Set 1 #

Total comments: 3

Patch Set 2 : Cleaner disabling of profiling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M src/d8.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/cpu-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 1 4 chunks +12 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/v8utils.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Brad Chen
PTAL
7 years, 8 months ago (2013-04-05 04:00:47 UTC) #1
ulan
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084 src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native Client. Is ...
7 years, 8 months ago (2013-04-08 11:27:10 UTC) #2
Brad Chen
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084 src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native Client. On ...
7 years, 8 months ago (2013-04-08 16:29:56 UTC) #3
Brad Chen
https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc File src/platform-linux.cc (right): https://codereview.chromium.org/13704002/diff/1/src/platform-linux.cc#newcode1084 src/platform-linux.cc:1084: // Profiling is disabled for x86_64 Native Client. On ...
7 years, 8 months ago (2013-04-08 16:38:32 UTC) #4
ulan
> I will change the #ifdef to disable for Native Client on all platforms. Okay? ...
7 years, 8 months ago (2013-04-09 07:38:18 UTC) #5
Brad Chen
On 2013/04/09 07:38:18, ulan wrote: > > I will change the #ifdef to disable for ...
7 years, 8 months ago (2013-04-09 14:59:19 UTC) #6
ulan
LGTM, I will land it for you.
7 years, 8 months ago (2013-04-09 15:05:29 UTC) #7
ulan
7 years, 8 months ago (2013-04-09 15:12:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r14187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698