Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.h

Issue 137023008: Add support for Tegra V4L2 VDA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use scopedFD for dmabuf fds. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/v4l2_video_decode_accelerator.h
diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.h b/content/common/gpu/media/v4l2_video_decode_accelerator.h
index 0c6a4930714de29f9a10d33975255dc90d011f26..f4645ce52d537a76504e1ee97d3d4d883978742d 100644
--- a/content/common/gpu/media/v4l2_video_decode_accelerator.h
+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.h
@@ -155,7 +155,6 @@ class CONTENT_EXPORT V4L2VideoDecodeAccelerator
~OutputRecord();
bool at_device; // held by device.
bool at_client; // held by client.
- int fds[2]; // file descriptors for each plane.
EGLImageKHR egl_image; // EGLImageKHR for the output buffer.
EGLSyncKHR egl_sync; // sync the compositor's use of the EGLImage.
int32 picture_id; // picture buffer id as returned to PictureReady().
@@ -294,6 +293,13 @@ class CONTENT_EXPORT V4L2VideoDecodeAccelerator
// Callback that indicates a picture has been cleared.
void PictureCleared();
+ // This method determines whether a resolution change event processing
+ // is indeed required by returning true if either:
+ // - width or height of the new format is different than previous format.
+ // - V4L2_CID_MIN_BUFFERS_FOR_CAPTURE has changed.
+ // Returns false otherwise.
+ bool IsResolutionChangeNecessary();
+
// Our original calling message loop for the child thread.
scoped_refptr<base::MessageLoopProxy> child_message_loop_proxy_;
@@ -426,6 +432,9 @@ class CONTENT_EXPORT V4L2VideoDecodeAccelerator
// The codec we'll be decoding for.
media::VideoCodecProfile video_profile_;
+ // Stores the number of planes (i.e. separate memory buffers) for output.
+ uint8 output_planes_count_;
Pawel Osciak 2014/03/28 06:21:46 s/uint8/size_t/
shivdasp 2014/03/28 06:40:43 Done.
+
DISALLOW_COPY_AND_ASSIGN(V4L2VideoDecodeAccelerator);
};

Powered by Google App Engine
This is Rietveld 408576698