Add support for Tegra V4L2 VDA

content/common/gpu/media/v4l2_video_device.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the V4L2Device interface which is used by the
 // V4L2DecodeAccelerator class to delegate/pass the device specific
 // handling of any of the functionalities.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_
 #define CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_
 
+#include "ui/gl/gl_bindings.h"
+
 namespace content {
 
 class V4L2Device {
  public:
   V4L2Device();
   virtual ~V4L2Device();
 
   // Tries to create and initialize an appropriate V4L2Device object for the
   // current platform and returns a scoped_ptr<V4L2Device> on success else
   // returns NULL.
-  static scoped_ptr<V4L2Device> Create();
+  static scoped_ptr<V4L2Device> Create(EGLContext egl_context);
 
   // Parameters and return value are the same as for the standard ioctl() system
   // call.
   virtual int Ioctl(int request, void* arg) = 0;
 
   // This method sleeps until either:
   // - SetDevicePollInterrupt() is called (on another thread),
   // - |poll_device| is true, and there is new data to be read from the device,
   //   or an event from the device has arrived; in the latter case
   //   |*event_pending| will be set to true.
@@ skipping 10 matching lines @@
   virtual bool SetDevicePollInterrupt() = 0;
   virtual bool ClearDevicePollInterrupt() = 0;
 
   // Wrappers for standard mmap/munmap system calls.
   virtual void* Mmap(void* addr,
                      unsigned int len,
                      int prot,
                      int flags,
                      unsigned int offset) = 0;
   virtual void Munmap(void* addr, unsigned int len) = 0;
+
+  // Does all the initialization of V4L2Device, returns true on success.
+  virtual bool Initialize() = 0;
+
+  // This method is used to create the EglImage since each V4L2Device

[Pawel Osciak, 2014/03/25 08:21:08]

s/the EglImage/an EGLImage/

[shivdasp, 2014/03/25 10:36:40]

Done.

+  // may have its own format. The texture_id is used to bind the

[Pawel Osciak, 2014/03/25 08:21:08]

s/format/may use a different method of acquiring one and associating it to the
given texture/

[shivdasp, 2014/03/25 10:36:40]

Done.

[Pawel Osciak, 2014/03/27 05:18:06]

If I may suggest please, it is an agreed practice in this review tool to respond
"done" when uploading a new patch set that actually fixes the issue. This helps
with missing some of the comments like in this case.

The documentation still needs updating please. Here and in other places please.

[shivdasp, 2014/03/27 05:40:37]

Apologies. I missed it. Will make a note of this.
On 2014/03/27 05:18:06, Pawel Osciak wrote:

+  // texture to the created eglImage. buffer_index can be used to associate
+  // the created EglImage by the underlying V4L2Device implementation.
+  virtual EGLImageKHR CreateEGLImage(EGLDisplay egl_display,
+                                     const EGLint* attrib,
+                                     GLuint texture_id,
+                                     unsigned int buffer_index) = 0;
+
+  // This method returns the supported texture target for the V4L2Device.
+  virtual GLenum GetTextureTarget() = 0;
 };
+
 }  //  namespace content
 
 #endif  //  CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_