Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 13702002: Unpoison gclient checkouts by setting recurseSubmodules=false (Closed)

Created:
7 years, 8 months ago by iannucci
Modified:
7 years, 8 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Unpoison gclient checkouts by setting recurseSubmodules=false This was causing extremely slow gclient sync's, and was preventing gclient from outputting anything if a slow submodule needed significant updating. R=cmp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gclient_scm.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
iannucci
7 years, 8 months ago (2013-04-05 03:34:53 UTC) #1
cmp
lgtm This is the second half of this change. The first half we landed late ...
7 years, 8 months ago (2013-04-05 03:35:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/13702002/1
7 years, 8 months ago (2013-04-05 03:36:02 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 03:38:11 UTC) #4
Message was sent while issue was closed.
Change committed as 192475

Powered by Google App Engine
This is Rietveld 408576698