Provide a mechanism to the decl. WebRequest API to match URLs without the query against a RegEx

Provide a mechanism to the decl. WebRequest API to match URLs without the query against a RegEx

If you look for URLs that contain example[1-9].com you do not want to trigger
actions for http://foobar.com?url=example1.com. For this reason the CL
introduces a new mechanism to evaluate RegEx only on the URL without the query
string.

BUG=228852
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193714

[battre, 2013-04-08 18:04:28]

Hi Yoyo,

could you please review this CL?

Thanks a lot!
Dominic

[Yoyo Zhou, 2013-04-08 18:20:43]

LGTM

https://codereview.chromium.org/13699007/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/events.json (right):

https://codereview.chromium.org/13699007/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/events.json:274: "strippedUrlMatches": {
This is not my favorite name but I can't think of a better one. RFCs call this
the "hierarchical part" but that name is less understandable.

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
File extensions/common/matcher/url_matcher.cc (right):

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
extensions/common/matcher/url_matcher.cc:392: static std::string
CanonicalizeURLForRegexSearchesHelper(
static function: should this be in the anonymous namespace instead?

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
File extensions/common/matcher/url_matcher_constants.h (right):

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
extensions/common/matcher/url_matcher_constants.h:34: extern const char
kStrippedURLMatchesKey[];
nit: alphabetize

[battre, 2013-04-09 12:22:23]

https://codereview.chromium.org/13699007/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/events.json (right):

https://codereview.chromium.org/13699007/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/events.json:274: "strippedUrlMatches": {
On 2013/04/08 18:20:43, Yoyo Zhou wrote:
> This is not my favorite name but I can't think of a better one. RFCs call this
> the "hierarchical part" but that name is less understandable.

Discussed this with Jeffrey and we concluded that originAndPathMatches might
work.

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
File extensions/common/matcher/url_matcher.cc (right):

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
extensions/common/matcher/url_matcher.cc:392: static std::string
CanonicalizeURLForRegexSearchesHelper(
On 2013/04/08 18:20:43, Yoyo Zhou wrote:
> static function: should this be in the anonymous namespace instead?

I considered this but concluded that it is more readable to have it in this
place. Otherwise we would need a different function name than "...Helper" and I
could not come up with a good one.

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
File extensions/common/matcher/url_matcher_constants.h (right):

https://codereview.chromium.org/13699007/diff/1/extensions/common/matcher/url...
extensions/common/matcher/url_matcher_constants.h:34: extern const char
kStrippedURLMatchesKey[];
On 2013/04/08 18:20:43, Yoyo Zhou wrote:
> nit: alphabetize

Done.

[commit-bot: I haz the power, 2013-04-11 16:44:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/13699007/12001

[commit-bot: I haz the power, 2013-04-11 18:54:03]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-04-11 18:56:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/13699007/12001

[commit-bot: I haz the power, 2013-04-11 20:04:07]

Change committed as 193714