Only hide menus when scrolls come from sources other than inside the menu itself.

Only hide menus when scrolls come from sources other than inside the menu itself.

R=estade@chromium.org
BUG=227498
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192929

[Evan Stade, 2013-04-08 18:25:44]

lgtm


-- Evan Stade


On Mon, Apr 8, 2013 at 10:06 AM, <dbeam@chromium.org> wrote:

> Reviewers: Evan Stade,
>
> Description:
> Only hide menus when scrolls come from sources other than inside the menu
> itself.
>
> R=estade@chromium.org
> BUG=227498
>
>
> Please review this at
https://codereview.chromium.**org/13699005/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ui/webui/resources/js/cr/ui/**menu_button.js
>
>
> Index: ui/webui/resources/js/cr/ui/**menu_button.js
> diff --git a/ui/webui/resources/js/cr/ui/**menu_button.js
> b/ui/webui/resources/js/cr/ui/**menu_button.js
> index de8958bb0697daba0bc947b10539b4**92ec26296c..**
> 7e791635e71ffdf29db752d4c4f0fa**868131e839 100644
> --- a/ui/webui/resources/js/cr/ui/**menu_button.js
> +++ b/ui/webui/resources/js/cr/ui/**menu_button.js
> @@ -103,8 +103,8 @@ cr.define('cr.ui', function() {
>
>            // Hide the focus ring on mouse click.
>            this.classList.add('using-**mouse');
> -
>            break;
> +
>          case 'keydown':
>            this.handleKeyDown(e);
>            // If the menu is visible we let it handle all the keyboard
> events.
> @@ -118,6 +118,7 @@ cr.define('cr.ui', function() {
>            // Show the focus ring on keypress.
>            this.classList.remove('using-**mouse');
>            break;
> +
>          case 'focus':
>            if (!this.contains(e.target) && !this.menu.contains(e.target)) {
>              this.hideMenu();
> @@ -127,12 +128,18 @@ cr.define('cr.ui', function() {
>              this.classList.remove('using-**mouse');
>            }
>            break;
> +
>          case 'activate':
>            var hideDelayed = e.target instanceof cr.ui.MenuItem &&
>                e.target.checkable;
>            this.hideMenu(hideDelayed ? HideType.DELAYED :
> HideType.INSTANT);
>            break;
> +
>          case 'scroll':
> +          if (!this.contains(e.target))
> +            this.hideMenu();
> +          break;
> +
>          case 'resize':
>            this.hideMenu();
>            break;
>
>
>

[commit-bot: I haz the power, 2013-04-08 18:42:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/13699005/5001

[commit-bot: I haz the power, 2013-04-08 18:56:19]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-08 18:59:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/13699005/5001

[commit-bot: I haz the power, 2013-04-08 22:24:08]

Change committed as 192929