chrome/browser/autofill/autofill_browsertest.cc - Issue 13697002: Make autofill's Address store country using the country code so that app locale isn't needed for th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 13697002: Make autofill's Address store country using the country code so that app locale isn't needed for th… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/android/personal_data_manager_android.cc ('K') | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | chrome/browser/ui/webui/options/autofill_options_handler.cc » ('j') | chrome/browser/webdata/autofill_profile_syncable_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_browsertest.cc

===================================================================

--- chrome/browser/autofill/autofill_browsertest.cc (revision 192389)

+++ chrome/browser/autofill/autofill_browsertest.cc (working copy)

@@ -1017,7 +1017,7 @@

L"\u898f\u7ba1\u5c0e\u904a"));

profile1.SetRawInfo(ADDRESS_HOME_ZIP, WideToUTF16(L"YOHO_54676"));

profile1.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, WideToUTF16(L"861088828000"));

- profile1.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"India"), "en-US");

Ilya Sherman 2013/04/05 05:18:01 Please preserve this; it should continue to work.

jam 2013/04/05 06:45:54 Done. i don't know what i was thinking when I chan

+ profile1.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"IN"), "en-US");

profiles.push_back(profile1);

AutofillProfile profile2;

@@ -1084,8 +1084,7 @@

profile7.SetRawInfo(ADDRESS_HOME_STATE, WideToUTF16(L"CA"));

profile7.SetRawInfo(ADDRESS_HOME_ZIP, WideToUTF16(L"94086"));

profile7.SetRawInfo(PHONE_HOME_WHOLE_NUMBER, WideToUTF16(L"15466784565"));

- profile7.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"United States"),

Ilya Sherman 2013/04/05 05:18:01 Ditto.

- "en-US");

+ profile7.SetInfo(ADDRESS_HOME_COUNTRY, WideToUTF16(L"US"), "en-US");

profiles.push_back(profile7);

SetProfiles(&profiles);

@@ -1156,8 +1155,7 @@

without_invalid.SetRawInfo(ADDRESS_HOME_CITY, ASCIIToUTF16("Sunnyvale"));

without_invalid.SetRawInfo(ADDRESS_HOME_STATE, ASCIIToUTF16("CA"));

without_invalid.SetRawInfo(ADDRESS_HOME_ZIP, ASCIIToUTF16("my_zip"));

- without_invalid.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("United States"),

Ilya Sherman 2013/04/05 05:18:01 Ditto.

jam 2013/04/05 06:45:54 Done.

- "en-US");

+ without_invalid.SetInfo(ADDRESS_HOME_COUNTRY, ASCIIToUTF16("US"), "en-US");

AutofillProfile with_invalid = without_invalid;

with_invalid.SetRawInfo(PHONE_HOME_WHOLE_NUMBER,