Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: content/renderer/render_widget.h

Issue 1369603003: Remove 2-stage RenderWidget initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@use_offscreen_contexts
Patch Set: fix racy test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 82646cd80388353bff20b19c99e0db1756f124ab..4a744abd131a5e91fe150a7b4a51d0436d8ab54e 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -364,8 +364,7 @@ class CONTENT_EXPORT RenderWidget
// Creates a WebWidget based on the popup type.
static blink::WebWidget* CreateWebWidget(RenderWidget* render_widget);
- // Initializes this view with the given opener. CompleteInit must be called
- // later.
+ // Initializes this view with the given opener.
bool Init(int32 opener_id);
// Called by Init and subclasses to perform initialization.
@@ -373,9 +372,6 @@ class CONTENT_EXPORT RenderWidget
blink::WebWidget* web_widget,
IPC::SyncMessage* create_widget_message);
- // Finishes creation of a pending view started with Init.
- void CompleteInit();
-
// Sets whether this RenderWidget has been swapped out to be displayed by
// a RenderWidget in a different process. If so, no new IPC messages will be
// sent (only ACKs) and the process is free to exit when there are no other
@@ -606,8 +602,6 @@ class CONTENT_EXPORT RenderWidget
// The rect where this view should be initially shown.
gfx::Rect initial_rect_;
- bool init_complete_;
-
// We store the current cursor object so we can avoid spamming SetCursor
// messages.
WebCursor current_cursor_;

Powered by Google App Engine
This is Rietveld 408576698