Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: media/cast/rtcp/rtcp.cc

Issue 136903003: cast: Wire upp logging to be sent over RTCP between receiver and sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge TOT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/logging/logging_unittest.cc ('k') | media/cast/rtcp/rtcp_receiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/rtcp/rtcp.cc
diff --git a/media/cast/rtcp/rtcp.cc b/media/cast/rtcp/rtcp.cc
index 922487591cfded5946ed669ed07f8005370d4965..c782b62a5b072195e0b213c2a1117d3685c32c7c 100644
--- a/media/cast/rtcp/rtcp.cc
+++ b/media/cast/rtcp/rtcp.cc
@@ -98,13 +98,15 @@ class LocalRtcpReceiverFeedback : public RtcpReceiverFeedback {
it->event_log_messages_.begin();
for (; event_it != it->event_log_messages_.end(); ++event_it) {
switch (event_it->type) {
- case kPacketReceived:
+ case kAudioPacketReceived:
+ case kVideoPacketReceived:
case kDuplicatePacketReceived:
cast_environment_->Logging()->InsertPacketEvent(
event_it->event_timestamp, event_it->type, rtp_timestamp,
kFrameIdUnknown, event_it->packet_id, 0, 0);
break;
- case kAckSent:
+ case kAudioAckSent:
+ case kVideoAckSent:
case kAudioFrameDecoded:
case kVideoFrameDecoded:
cast_environment_->Logging()->InsertFrameEvent(
@@ -260,8 +262,6 @@ void Rtcp::SendRtcpFromRtpReceiver(const RtcpCastMessage* cast_message,
if (cast_message) {
packet_type_flags |= RtcpSender::kRtcpCast;
- cast_environment_->Logging()->InsertGenericEvent(now, kAckSent,
- cast_message->ack_frame_id_);
}
if (receiver_log) {
packet_type_flags |= RtcpSender::kRtcpReceiverLog;
@@ -281,7 +281,6 @@ void Rtcp::SendRtcpFromRtpReceiver(const RtcpCastMessage* cast_message,
report_block.jitter);
cast_environment_->Logging()->InsertGenericEvent(now, kPacketLoss,
report_block.fraction_lost);
-
}
report_block.last_sr = last_report_received_;
« no previous file with comments | « media/cast/logging/logging_unittest.cc ('k') | media/cast/rtcp/rtcp_receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698