Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: media/cast/logging/logging_defines.h

Issue 136903003: cast: Wire upp logging to be sent over RTCP between receiver and sender. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge TOT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/audio_sender/audio_sender_unittest.cc ('k') | media/cast/logging/logging_defines.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/logging_defines.h
diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h
index c09a188c82efc34a9d0cc45066fbfcbcde33140b..f23aeb1ebbb12fa792a04477ab6922d02b117f84 100644
--- a/media/cast/logging/logging_defines.h
+++ b/media/cast/logging/logging_defines.h
@@ -18,9 +18,10 @@ namespace cast {
static const uint32 kFrameIdUnknown = 0xFFFF;
struct CastLoggingConfig {
- CastLoggingConfig();
+ CastLoggingConfig(bool sender);
~CastLoggingConfig();
+ bool is_sender;
bool enable_raw_data_collection;
bool enable_stats_data_collection;
bool enable_uma_stats;
@@ -28,7 +29,8 @@ struct CastLoggingConfig {
};
// By default, enable raw and stats data collection. Disable tracing and UMA.
-CastLoggingConfig GetDefaultCastLoggingConfig();
+CastLoggingConfig GetDefaultCastSenderLoggingConfig();
+CastLoggingConfig GetDefaultCastReceiverLoggingConfig();
enum CastLoggingEvent {
// Generic events.
@@ -36,9 +38,10 @@ enum CastLoggingEvent {
kRttMs,
kPacketLoss,
kJitterMs,
- kAckReceived,
+ kVideoAckReceived,
kRembBitrate,
- kAckSent,
+ kAudioAckSent,
+ kVideoAckSent,
// Audio sender.
kAudioFrameReceived,
kAudioFrameCaptured,
@@ -59,7 +62,8 @@ enum CastLoggingEvent {
kPacketSentToNetwork,
kPacketRetransmitted,
// Receive-side packet events.
- kPacketReceived,
+ kAudioPacketReceived,
+ kVideoPacketReceived,
kDuplicatePacketReceived,
kNumOfLoggingEvents,
@@ -116,11 +120,24 @@ struct FrameLogStats {
int avg_delay_ms;
};
+struct ReceiverRtcpEvent {
+ ReceiverRtcpEvent();
+ ~ReceiverRtcpEvent();
+
+ CastLoggingEvent type;
+ base::TimeTicks timestamp;
+ base::TimeDelta delay_delta; // Render/playout delay.
+ uint16 packet_id;
+};
+
// Store all log types in a map based on the event.
typedef std::map<uint32, FrameEvent> FrameRawMap;
typedef std::map<uint32, PacketEvent> PacketRawMap;
typedef std::map<CastLoggingEvent, GenericEvent> GenericRawMap;
+typedef std::multimap<uint32, ReceiverRtcpEvent> AudioRtcpRawMap;
+typedef std::multimap<uint32, ReceiverRtcpEvent> VideoRtcpRawMap;
+
typedef std::map<CastLoggingEvent, linked_ptr<FrameLogStats > > FrameStatsMap;
typedef std::map<CastLoggingEvent, double> PacketStatsMap;
typedef std::map<CastLoggingEvent, double> GenericStatsMap;
« no previous file with comments | « media/cast/audio_sender/audio_sender_unittest.cc ('k') | media/cast/logging/logging_defines.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698