Added UMA metrics for MediaSourcePlayer and MediaCodecPlayer

media/base/android/media_codec_decoder.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/android/media_codec_decoder.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback_helpers.h"
 #include "base/logging.h"
@@ skipping 21 matching lines @@
 }
 
 MediaCodecDecoder::MediaCodecDecoder(
     const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
     const base::Closure& external_request_data_cb,
     const base::Closure& starvation_cb,
     const base::Closure& decoder_drained_cb,
     const base::Closure& stop_done_cb,
     const base::Closure& key_required_cb,
     const base::Closure& error_cb,
-    const char* decoder_thread_name)
+    const char* decoder_thread_name,
+    FrameStatistics* frame_statistics)
     : media_task_runner_(media_task_runner),
       decoder_thread_(decoder_thread_name),
+      frame_statistics_(frame_statistics),
       needs_reconfigure_(false),
       drain_decoder_(false),
       always_reconfigure_for_tests_(false),
       external_request_data_cb_(external_request_data_cb),
       starvation_cb_(starvation_cb),
       decoder_drained_cb_(decoder_drained_cb),
       stop_done_cb_(stop_done_cb),
       key_required_cb_(key_required_cb),
       error_cb_(error_cb),
       state_(kStopped),
@@ skipping 445 matching lines @@
   // Set [kInEmergencyStop| state to block already posted ProcessNextFrame().
   SetState(kInEmergencyStop);
 
   decoder_thread_.Stop();  // synchronous
 
   SetState(kStopped);
 
   key_request_posted_ = false;
 }
 
-void MediaCodecDecoder::CheckLastFrame(bool eos_encountered,
+bool MediaCodecDecoder::CheckLastFrame(bool eos_encountered,
                                        bool has_delayed_tasks) {
   DCHECK(decoder_thread_.task_runner()->BelongsToCurrentThread());
 
   bool last_frame_when_stopping = GetState() == kStopping && !has_delayed_tasks;
 
   if (last_frame_when_stopping || eos_encountered) {
     media_task_runner_->PostTask(
         FROM_HERE, base::Bind(&MediaCodecDecoder::OnLastFrameRendered,
                               weak_factory_.GetWeakPtr(), eos_encountered));
     last_frame_posted_ = true;
   }
+  return last_frame_posted_;

[xhwang, 2015/09/30 21:02:57]

nit: a boolean variable should be named as is_* or has_*. When looking at this
my first reaction is that this returns the last frame that is posted.

[Tima Vaisburd, 2015/10/01 20:05:15]

This change is undone.

 }
 
 void MediaCodecDecoder::OnCodecError() {
   DCHECK(media_task_runner_->BelongsToCurrentThread());
 
   // Ignore codec errors from the moment surface is changed till the
   // |media_codec_bridge_| is deleted.
   if (needs_reconfigure_) {
     DVLOG(1) << class_name() << "::" << __FUNCTION__
              << ": needs reconfigure, ignoring";
@@ skipping 414 matching lines @@
     RETURN_STRING(kStopping);
     RETURN_STRING(kInEmergencyStop);
     RETURN_STRING(kError);
   }
   return nullptr;  // crash early
 }
 
 #undef RETURN_STRING
 
 }  // namespace media