Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13674022: Remove MEDIA_SOURCE feature define. (Closed)

Created:
7 years, 8 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 8 months ago
CC:
blink-reviews, Stephen Chennney, Nate Chapin, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@blink-master
Visibility:
Public.

Description

Remove MEDIA_SOURCE feature define since all Chromium builds have the MediaSource API enabled by default. BUG=227180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147701

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -185 lines) Patch
M Source/WTF/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/mediasource/MediaSource.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/mediasource/MediaSource.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/mediasource/MediaSource.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/mediasource/MediaSourceRegistry.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBuffer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBufferList.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBufferList.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/mediasource/SourceBufferList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/dom/EventTargetFactory.in View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/DOMURL.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/DOMURL.cpp View 5 chunks +2 lines, -9 lines 0 comments Download
M Source/WebCore/html/DOMURL.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 1 16 chunks +4 lines, -31 lines 0 comments Download
M Source/WebCore/html/PublicURLManager.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebCore/platform/MIMETypeRegistry.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.cpp View 7 chunks +2 lines, -14 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaSourcePrivate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/graphics/SourceBufferPrivate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/AssertMatchingEnums.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/MediaSourcePrivateImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/MediaSourcePrivateImpl.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/SourceBufferPrivateImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/SourceBufferPrivateImpl.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaSourceImpl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebMediaSourceImpl.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Tools/Scripts/webkitperl/FeatureList.pm View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 8 months ago (2013-04-05 21:45:17 UTC) #1
eseidel
Ideally the change description would have more context to make reviews easier. :) It looks ...
7 years, 8 months ago (2013-04-05 21:54:06 UTC) #2
acolwell GONE FROM CHROMIUM
7 years, 8 months ago (2013-04-05 23:22:30 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r147701 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698