Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 13674021: [Android] Extend setup timeout for content_browsertests. (Closed)

Created:
7 years, 8 months ago by newt (away)
Modified:
7 years, 8 months ago
Reviewers:
craigdh, frankf, nilesh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Extend setup timeout for content_browsertests. content_browsertests were timing out on the Android FYI bots since it took more than 7 minutes to push the test files to the device. This extends the timeout to 20 minutes, as a stopgap until we can reduce the number of files that need to be pushed. BUG=138275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192682

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/browsertests/dispatch.py View 1 chunk +4 lines, -0 lines 4 comments Download

Messages

Total messages: 10 (0 generated)
newt (away)
7 years, 8 months ago (2013-04-05 21:10:57 UTC) #1
frankf
7 years, 8 months ago (2013-04-05 21:15:53 UTC) #2
nilesh
https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py#newcode71 build/android/pylib/browsertests/dispatch.py:71: test_timeout=None) we also need more than 7 mins to ...
7 years, 8 months ago (2013-04-05 21:23:54 UTC) #3
newt (away)
https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py#newcode71 build/android/pylib/browsertests/dispatch.py:71: test_timeout=None) On 2013/04/05 21:23:54, nilesh wrote: > we also ...
7 years, 8 months ago (2013-04-05 21:41:24 UTC) #4
craigdh
lgtm. https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py#newcode71 build/android/pylib/browsertests/dispatch.py:71: test_timeout=None) On 2013/04/05 21:41:25, newt wrote: > On ...
7 years, 8 months ago (2013-04-05 22:00:02 UTC) #5
nilesh
On 2013/04/05 22:00:02, craigdh wrote: > lgtm. > > https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py > File build/android/pylib/browsertests/dispatch.py (right): > ...
7 years, 8 months ago (2013-04-05 22:05:23 UTC) #6
nilesh
lgtm
7 years, 8 months ago (2013-04-05 22:10:12 UTC) #7
craigdh
https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py File build/android/pylib/browsertests/dispatch.py (right): https://codereview.chromium.org/13674021/diff/1/build/android/pylib/browsertests/dispatch.py#newcode71 build/android/pylib/browsertests/dispatch.py:71: test_timeout=None) On 2013/04/05 22:00:03, craigdh wrote: > On 2013/04/05 ...
7 years, 8 months ago (2013-04-05 22:18:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/13674021/1
7 years, 8 months ago (2013-04-05 23:10:09 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 01:10:42 UTC) #10
Message was sent while issue was closed.
Change committed as 192682

Powered by Google App Engine
This is Rietveld 408576698